Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pycodestyle 2.7.0 #589

Merged
merged 1 commit into from Mar 16, 2021
Merged

Conversation

heavenshell
Copy link
Contributor

@heavenshell heavenshell commented Mar 16, 2021

Hello.

flake8 3.9.0 was released and it's depeneds pycodestyle 2.7.0
However autopep depends pycodestyle 2.6.0

In my project, flake8 and autopep8 has been conflicting.

The conflict is caused by:
    autopep8 1.5.5 depends on pycodestyle>=2.6.0
    flake8 3.9.0 depends on pycodestyle<2.8.0 and >=2.7.0

This PR updates pycodestyle>=2.7.0

I update pycodestyle 2.7.0 and run tests works fine.
So I think it's OK to update.

Is there any blocker to update pycodestyle 2.7.0?
If update 2.7.0 is OK, please include this and release to PyPi 馃檹

$ pip freeze
pycodestyle==2.7.0
toml==0.10.2

$ make test
--->  Running basic test
pycodestyle --repeat .tmp.test.py
--->  Running --diff test
patch < .tmp.example.py.patch
patching file .tmp.example.py
pycodestyle --repeat .tmp.example.py && python -m py_compile .tmp.example.py
--->  Running unit tests
........./tmp/autopep8/autopep8.py:197: PendingDeprecationWarning: lib2to3 package is deprecated and may not be able to parse Python 3.10+
  from lib2to3.pgen2 import tokenize as lib2to3_tokenize
................./opt/local/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/unittest/case.py:550: ResourceWarning: unclosed file <_io.BufferedReader name=3>
  method()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
...............[file:/var/folders/wk/pygq97bn6ssffysmw10b3xb80000gn/T/autopep8test2z2qvu3s/foo.py]
--->  0 issue(s) to fix {}
...............s......................................s.........................s...............................................................................................................................................................................................................................................................................................................................................................s.........................................................................................................
----------------------------------------------------------------------
Ran 579 tests in 41.713s

OK (skipped=4)

@codecov-io
Copy link

Codecov Report

Merging #589 (76f6cb8) into master (ab9760c) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
+ Coverage   97.77%   97.81%   +0.04%     
==========================================
  Files           1        1              
  Lines        2338     2338              
==========================================
+ Hits         2286     2287       +1     
+ Misses         52       51       -1     
Impacted Files Coverage 螖
autopep8.py 97.81% <0.00%> (+0.04%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ab9760c...76f6cb8. Read the comment docs.

Copy link
Owner

@hhatto hhatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

Thanks

@hhatto hhatto merged commit 5adf197 into hhatto:master Mar 16, 2021
@hhatto
Copy link
Owner

hhatto commented Mar 16, 2021

ref: pycodestyle v2.7.0 changelog

@heavenshell heavenshell deleted the topic/pycodestyle2.7.0 branch March 16, 2021 14:43
@hhatto hhatto added this to the 1.5.6 milestone Mar 16, 2021
@heavenshell
Copy link
Contributor Author

Thank you!!

This was referenced Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants