Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

continued_indentation: Make the E128 check similar to pycodestyle #585

Merged
merged 2 commits into from Feb 25, 2021
Merged

continued_indentation: Make the E128 check similar to pycodestyle #585

merged 2 commits into from Feb 25, 2021

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Feb 24, 2021

Maybe a simple botch in the following commit:

commit 0f06de12f6a1eaab646089f7c38f1d38a035967c
Author: Steven Myint <git@stevenmyint.com>
Date:   Sat Sep 7 12:52:08 2013 -0700

    Get indentation information directly from pep8

    This greatly speeds up the "E12" indentation fixes.

A small test case:

a = {x: f(x,
     x)
     for x in xs}
  • autopep8 without this commit complains E128.
  • pycodestyle 2.6.0 doesn't complain.
  • autopep8 with this commit doesn't complain.

@yamt
continued_indentation: Make the E128 check similar to pycodestyle
4062dc6 
Maybe a simple botch in the following commit:

```
commit 0f06de1
Author: Steven Myint <git@stevenmyint.com>
Date:   Sat Sep 7 12:52:08 2013 -0700

    Get indentation information directly from pep8

    This greatly speeds up the "E12" indentation fixes.
```

A small test case:
```
a = {x: f(x,
     x)
     for x in xs}
```
* autopep8 without this commit complains E128.
* pycodestyle 2.6.0 doesn't complain.
* autopep8 with this commit doesn't complain.
@yamt
Update test_autopep8.py after continued_indentation fix
67f1956 
While I'm not a pep8-laywer, pycodestyle seems to allow either styles.
@hhatto hhatto assigned hhatto and unassigned hhatto Feb 24, 2021
@hhatto hhatto self-requested a review February 24, 2021 07:54
@hhatto hhatto added this to the 2.0 milestone Feb 25, 2021
hhatto
hhatto approved these changes Feb 25, 2021
View reviewed changes
Copy link
Owner

@hhatto hhatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
LGTM 👍

@hhatto hhatto merged commit ab9760c into hhatto:master Feb 25, 2021
This was referenced Mar 16, 2021
Merged
Merged
Merged
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Merged
This was referenced Mar 17, 2021
Merged
Closed
Closed
@hhatto hhatto modified the milestones: 2.0, 1.5.6 Mar 17, 2021
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhatto hhatto hhatto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yamt @hhatto