creates syntax error with -aa --select=E,W

[markblundeberg]

---

Python Code

I put if True: just for indentation purposes. This is excerpt from here:

if True:
    if True:
        assert_equal(self.nodes[0].getbalance(
        ), bal + Decimal('50.00000000') + Decimal('2.19000000'))  # block reward + tx

Command Line

$ autopep8 -aa --select=E,W --diff foo.py 

Output converts Decimal('50.00000000') + Decim... to Decimal('50.00 + 00000') Decim... (note that besides the movement of the +, one 0 is missing):

--- original/foo.py
+++ fixed/foo.py
@@ -1,4 +1,7 @@
 if True:
     if True:
-        assert_equal(self.nodes[0].getbalance(
-        ), bal + Decimal('50.00000000') + Decimal('2.19000000'))  # block reward + tx
+        assert_equal(
+            self.nodes[0].getbalance(),
+            bal +
+            Decimal('50.00 + 00000')
+            Decimal('2.19000000'))  # block reward + tx

Your Environment

• Python version: 3.7.4
• autopep8 version: autopep8 1.5 (pycodestyle: 2.5.0)
• Platform: linux pyenv

Also appears in autopep8 1.4.3 (pycodestyle: 2.4.0), on Python 3.7.3 -- Ubuntu 19.04 stock.

But does not appear in autopep8 1.3.4 (pycodestyle: 2.3.1) on Python 3.6.9 (pyenv).

[markblundeberg]

Possibly related, but separate bug: #463

If I remove the comment on end of line (and change 2.19000000 to 2.190000000000000000000000000 so the line is too long) then it introduces no error, but it does create bad indentation:

--- original/foo.py
+++ fixed/foo.py
@@ -1,4 +1,7 @@
 if True:
     if True:
-        assert_equal(self.nodes[0].getbalance(
-        ), bal + Decimal('50.00000000') + Decimal('2.190000000000000000000000000'))
+        assert_equal(
+            self.nodes[0].getbalance(),
+            bal +
+    Decimal('50.00000000') +
+            Decimal('2.190000000000000000000000000'))

[markblundeberg]

Another more specific version (starting from a good result from applying just E rules):

if True:
    if True:
        assert_equal(
            self.nodes[0].getbalance(),
            bal +
            Decimal('50.00000000') +
            Decimal('2.19000000'))  # block reward + tx

Output from autopep8 -aa --select=W --diff foo2.py or autopep8 -aa --select=W5 --diff foo2.py or just autopep8 -aa --select=W503,W504 --diff foo2.py:

+++ fixed/foo2.py
@@ -3,5 +3,5 @@
         assert_equal(
             self.nodes[0].getbalance(),
             bal +
-            Decimal('50.00000000') +
-            Decimal('2.19000000'))  # block reward + tx
+            Decimal('50.00 + 00000')
+ Decimal('2.19000000'))  # block reward + tx

Seems it doesn't like the mutually contradictory behaviour of W503, W504 ...

[hhatto]

When W, W5 and W50 are specified and W503 and W504 conflict, priority is given to W503.
This change is in #532 .

We will release version 1.5.1 with this change within two days.

Thanks