Skip to content

Simplify registry subclassing #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 26, 2022
Merged

Simplify registry subclassing #1633

merged 6 commits into from
Oct 26, 2022
+182 −15

Conversation

hgrecco
Copy link
Owner

@hgrecco hgrecco commented Oct 25, 2022 •
edited
Loading

Sorry, something went wrong.

@hgrecco
Copy link
Owner Author

hgrecco commented Oct 26, 2022

I have also added some docs in advanced / custom-registry-class

ping @jules-ch

mikapfl
mikapfl reviewed Oct 26, 2022
View reviewed changes
hgrecco and others added 3 commits October 26, 2022 08:54
@hgrecco @mikapfl
Typo fix in docs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f7f97ab 
Co-authored-by: Mika Pflüger <mika.pflueger@pik-potsdam.de>
@hgrecco
Test against macos
cc02904
@hgrecco
Move macos test to independent section
5e3c937
@hgrecco
Copy link
Owner Author

hgrecco commented Oct 26, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 26, 2022

Build succeeded:

@bors bors bot merged commit cf1a802 into master Oct 26, 2022
@bors bors bot deleted the develop branch October 26, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mikapfl mikapfl

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: Units from derived unit registry no longer instance of pint.Unit
2 participants
@hgrecco @mikapfl