Skip to content

Listing extra requirements in setup.cfg #1627

Closed
@hgrecco

Description

@hgrecco

I have noticed that our extra requirements is inconsistent. It currently looks like this.

numpy = numpy >= 1.19.5
uncertainties = uncertainties >= 3.1.6
test =
    pytest
    pytest-mpl
    pytest-cov
    pytest-subtests

Pint interacts with more projects (if available), not just numpy and uncertainties. My suggestion would be to include as independent lines everything that is optional: babel, pandas (which should install pint-pandas), xarray, dask.

Activity

hgrecco

hgrecco commented on Oct 24, 2022

@hgrecco
OwnerAuthor

Which versions should we specify for each package. The minimal would be:

[options.extras_require]
numpy = numpy >= 1.19.5
uncertainties = uncertainties >= 3.1.6
babel = babel >= 2.8
pandas = pint-pandas
xarray = xarray
dask = dask
test =
    pytest
    pytest-mpl
    pytest-cov
    pytest-subtests

but maybe we should be more strict?

andrewgsavage

andrewgsavage commented on Oct 25, 2022

@andrewgsavage
Collaborator

pint-pandas >= 0.3

jules-ch

jules-ch commented on Oct 25, 2022

@jules-ch
Collaborator

babel <= 2.8 for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @hgrecco@andrewgsavage@jules-ch

        Issue actions

          Listing extra requirements in setup.cfg · Issue #1627 · hgrecco/pint