Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system-ui in --font-sans font stack #85

Open
daniel-j-h opened this issue Oct 3, 2022 · 2 comments
Open

system-ui in --font-sans font stack #85

daniel-j-h opened this issue Oct 3, 2022 · 2 comments

Comments

@daniel-j-h
Copy link

Hey folks, I'm just seeing that we have system-ui in the sans font variable

sans: 'system-ui, -apple-system, Segoe UI, Roboto, Noto Sans, Ubuntu, Cantarell, Helvetica Neue',

and I was wondering if we should remove it as a default, since it's problematic for some users

At the moment I work around it by overwriting the default in my project via

:root { --font-sans: .. }

Also wondering how we came up with the font stack, and if we can rely on something like https://systemfontstack.com?

@madeleineostoja
Copy link
Contributor

I was under the impression that system-ui had significantly stabilised since those concerns? If that’s not the case then yep we can strip it out. Most production projects will overwrite these particular defaults anyway.

The current font stacks were taken from a postcss shim for system-ui, but your source looks v solid as well. Next time there’s a breaking change on the cards it would be worth updating them regardless.

As an aside it’ll be cleaner to overwrite / change anything you need in pollen with a config file rather than clobbering output css variables :)

@daniel-j-h
Copy link
Author

From what I can see, system-ui still has its problems, but I also understand that this change would require a new pollen release.

Thanks for the config pointers, looks awesome to customize pollen so easily with a config file! I'll look into it! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants