Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop Node.js 10 and add Node.js 16 #4691

Merged
merged 2 commits into from May 7, 2021
Merged

chore: drop Node.js 10 and add Node.js 16 #4691

merged 2 commits into from May 7, 2021

Conversation

stevenjoezhang
Copy link
Member

What does it do?

How to test

git clone -b BRANCH https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented May 1, 2021 •
edited

Coverage Status

Coverage remained the same at 98.282% when pulling 9f511b2 on node into 6e33bac on master.

@stevenjoezhang stevenjoezhang marked this pull request as ready for review May 1, 2021 13:43
yoshinorin
yoshinorin previously approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why few tests are failed.
But, I think probably they are no problem. We should start to drop Node.js v10.x.

@stevenjoezhang
Copy link
Member Author

The failed tests appears randomly. It might be caused by the race condition of parallel tests #4374

yoshinorin
yoshinorin approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenjoezhang stevenjoezhang merged commit b25956f into master May 7, 2021
@stevenjoezhang stevenjoezhang deleted the node branch May 7, 2021 16:30
@stevenjoezhang stevenjoezhang restored the node branch May 7, 2021 16:30
@stevenjoezhang stevenjoezhang deleted the node branch May 7, 2021 16:30
@stevenjoezhang stevenjoezhang restored the node branch May 7, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevenjoezhang @coveralls @yoshinorin