Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/ci: move profiling to Actions #4535

Merged
merged 4 commits into from Sep 16, 2020
Merged

chore/ci: move profiling to Actions #4535

merged 4 commits into from Sep 16, 2020

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Sep 15, 2020 •
edited

What does it do?

Continue #4525
Finally replace Travis.

Pull request tasks

- [ ] Add test cases for the changes.

  • Passed the CI test.

@curbengh curbengh changed the title Actions flamegraph chore/ci: move profiling to Actions Sep 15, 2020
@coveralls
Copy link

coveralls commented Sep 15, 2020 •
edited

Coverage Status

Coverage remained the same at 98.303% when pulling c7c3db2 on actions-flamegraph into b69e685 on master.

@curbengh
Copy link
Contributor Author

https://cc5083362a7a8f7b92347dfa81133c6b5ffd13b4-10-hexo.surge.sh/flamegraph.html
https://cc5083362a7a8f7b92347dfa81133c6b5ffd13b4-12-hexo.surge.sh/flamegraph.html
https://cc5083362a7a8f7b92347dfa81133c6b5ffd13b4-14-hexo.surge.sh/flamegraph.html

@curbengh curbengh requested a review from a team September 15, 2020 07:15
@curbengh curbengh added this to In progress in GitHub Actions via automation Sep 15, 2020
@curbengh curbengh marked this pull request as ready for review September 15, 2020 07:15
@curbengh curbengh mentioned this pull request Sep 15, 2020
Closed
1 task
curbengh
curbengh commented Sep 15, 2020
View reviewed changes
.github/workflows/benchmark.yml
@@ -16,7 +16,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: ['10.x', '12.x', '14.x']
node-version: ['10', '12', '14']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surge.sh's subdomain cannot have a dot, 10 & 10.x seem to produce similar result.

SukkaW
SukkaW reviewed Sep 15, 2020
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about making benchmark & profiling as two dedicated jobs?

# benchmark.yml
jobs:
  benchmark:
    runs-on: ${{ matrix.os }}
    #
  profiling:
    runs-on: ${{ matrix.os }}
    #

@SukkaW SukkaW merged commit d445b68 into master Sep 16, 2020
GitHub Actions automation moved this from In progress to Done Sep 16, 2020
@curbengh curbengh deleted the actions-flamegraph branch September 17, 2020 00:28
@SukkaW
Copy link
Member

SukkaW commented Sep 17, 2020

image

@curbengh

@stevenjoezhang stevenjoezhang mentioned this pull request Sep 26, 2020
Closed
@stevenjoezhang stevenjoezhang mentioned this pull request Oct 8, 2021
Merged
2 tasks
@stevenjoezhang
Copy link
Member

This workflow does not work for the fork repository because it does not have permission to access the surge token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
GitHub Actions
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@curbengh @coveralls @SukkaW @stevenjoezhang