Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(load_plugin): ignore pkg name endswith theme name #4497

Merged
merged 1 commit into from Aug 25, 2020
Merged

feat(load_plugin): ignore pkg name endswith theme name #4497

merged 1 commit into from Aug 25, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Aug 25, 2020

What does it do?

The first part of #4496. Prevent @user/hexo-theme-[name] being loaded as a plugin.

How to test

git clone -b npm-theme-owner https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested a review from a team August 25, 2020 13:41
@coveralls
Copy link

coveralls commented Aug 25, 2020 •
edited

Coverage Status

Coverage remained the same at 98.296% when pulling 3c89d09 on SukkaW:npm-theme-owner into 39da369 on hexojs:master.

@SukkaW SukkaW merged commit 08c8b23 into hexojs:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SukkaW @coveralls @stevenjoezhang