Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: 5.1.1 #4490

Merged
merged 1 commit into from
Aug 23, 2020
Merged

release: 5.1.1 #4490

merged 1 commit into from
Aug 23, 2020

Conversation

curbengh
Copy link
Contributor

What does it do?

emergency fix #4489

How to test

git clone -b BRANCH https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@curbengh curbengh requested a review from a team August 23, 2020 06:48
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.296% when pulling efa432b on curbengh:v5.1.1 into 5795c12 on hexojs:master.

@SukkaW
Copy link
Member

SukkaW commented Aug 23, 2020

LGTM!

BTW, should we deprecate Hexo 5.1.0 after Hexo 5.1.1 is released?

Although #4489 might not be a critical bug.

@curbengh
Copy link
Contributor Author

All versions 5.0.0-5.1.0 have this #4482 issue though; I agree it's not critical since most users use either of the code highlight libraries.

@curbengh curbengh merged commit 6635f2c into hexojs:master Aug 23, 2020
@curbengh curbengh deleted the v5.1.1 branch August 23, 2020 08:49
@inkss inkss mentioned this pull request Aug 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@curbengh @coveralls @SukkaW @stevenjoezhang