Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(highlight): parse 'caption' option to prismHighlight #4476

Merged
merged 4 commits into from
Aug 21, 2020
Merged

feat(highlight): parse 'caption' option to prismHighlight #4476

merged 4 commits into from
Aug 21, 2020

Conversation

curbengh
Copy link
Contributor

What does it do?

Feature requested in #4460 by @jerryc127

How to test

git clone -b prism-caption https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

@coveralls
Copy link

coveralls commented Aug 13, 2020 •
edited

Coverage Status

Coverage remained the same at 98.296% when pulling ae97b97 on curbengh:prism-caption into 8830389 on hexojs:master.

@curbengh curbengh marked this pull request as ready for review August 21, 2020 05:44
SukkaW
SukkaW reviewed Aug 21, 2020
View reviewed changes
test/scripts/filters/backtick_code_block.js
Comment on lines +451 to +455
describe('prismjs', () => {
beforeEach(() => {
hexo.config.highlight.enable = false;
hexo.config.prismjs.enable = true;
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@curbengh curbengh merged commit a7d6d8f into hexojs:master Aug 21, 2020
@curbengh curbengh deleted the prism-caption branch August 21, 2020 11:36
This was referenced Aug 21, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@curbengh @coveralls @SukkaW