Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(box): remove Bluebird.asCallback #4379

Merged
merged 1 commit into from Jul 11, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Jun 25, 2020

What does it do?

Remove the callback from box.

All hexo internal functions are not relied on box's callback, and box's callback usage is never mentioned in Hexo API documents: https://hexo.io/api/box

How to test

git clone -b reduce-ascallback-box https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Jun 25, 2020

Coverage Status

Coverage remained the same at 97.822% when pulling a6c44c3 on SukkaW:reduce-ascallback-box into 7ff1a70 on hexojs:master.

@SukkaW SukkaW marked this pull request as ready for review July 10, 2020 15:42
@SukkaW SukkaW merged commit 17ee23f into hexojs:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants