perf(meta_generator): drop cheerio #3671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regardless the value of 'content'
Previous commit only works on post, not page This reverts commit 325f303.
|
Maybe it's not necessary to use the xhml syntax?
|
curbengh
commented
Aug 16, 2019
curbengh
force-pushed
the
metagen-cheerio
branch
from
b5c3866
to
2a4fc33
Compare
curbengh
commented
Aug 16, 2019
|
btw, if anyone's worry about html in a code block, the brackets are encoded, <figure class="highlight html"><table><tbody><tr><td class="code"><pre><span class="line"><span class="tag"><<span class="name">head</span>></span><span class="tag"></<span class="name">head</span>></span></span><br></pre></td></tr></tbody></table></figure> |
SukkaW
added a commit
to theme-suka/performance-test
that referenced
this pull request
Aug 16, 2019
SukkaW
previously approved these changes
Aug 16, 2019
|
I forgot to add a unit test where Edit: added decreased coverage may be due to shorter lines/functions. |
2 tasks
curbengh
force-pushed
the
metagen-cheerio
branch
from
caa5aaa
to
fb42a5b
Compare
|
squashed some commits. |
SukkaW
approved these changes
Aug 18, 2019
4 tasks
curbengh
changed the title
2 tasks
thom4parisot
pushed a commit
to thom4parisot/hexo
that referenced
this pull request
Jan 17, 2020
* refactor(meta_generator): drop cheerio * fix(meta_generator): append to </title> * test(meta_generator): remove irrelevant head tag test * test(render): disable meta_generator * fix(meta_generator): do not append if there is existing tag, regardless the value of 'content' * test(open_generator): test existing generator tag * test(meta_generator): tag should be added only once Previous commit only works on post, not page This reverts commit 325f303.
curbengh
pushed a commit
to curbengh/curbengh.github.io
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Less breaking alternative to #3669
x-post from that PR:
How to test
Pull request tasks