Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate highlight auto-detect config #1786

Closed
leesei opened this issue Feb 29, 2016 · 1 comment
Closed

Deprecate highlight auto-detect config #1786

leesei opened this issue Feb 29, 2016 · 1 comment
Labels
wontfix This will not be worked on

Comments

@leesei
Copy link
Member

leesei commented Feb 29, 2016

Auto-detect is slow and may crash on specific input.
It is no longer recommended in Heo 3.2, original discussion in #1627
Now that:

  • default setting is false
  • util.highlight() default to plain if no lang is provided

I think we can deprecate auto-detect config and give a warning if it is defined.
@leesei leesei mentioned this issue Feb 29, 2016
Closed
@stevenjoezhang stevenjoezhang mentioned this issue Mar 6, 2020
Closed
@stevenjoezhang stevenjoezhang mentioned this issue Apr 25, 2020
Merged
@stevenjoezhang
Copy link
Member

stevenjoezhang commented Apr 25, 2020 •
edited

This option is required by highlight.js 10 and therefore cannot be removed. Related documents have been updated.

hexojs/hexo-util#196

@stevenjoezhang stevenjoezhang added the wontfix This will not be worked on label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leesei @stevenjoezhang