Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.0.0 following 1 year of changes #57

Merged
merged 7 commits into from Aug 19, 2019
Merged

Bump version to 1.0.0 following 1 year of changes #57

merged 7 commits into from Aug 19, 2019

Conversation

tomap
Copy link
Contributor

@tomap tomap commented Feb 25, 2019

to show that it is stable

@yoshinorin
Copy link
Member

+1

But, IMHO a package version up should just before publish.
I don't know package release plan of hexo. So, I can't judge update this package version or not.

@tomap
Copy link
Contributor Author

tomap commented Aug 3, 2019

Before we do that, I'm wondering if this file
highlight_alias.json
should not be published?
see the package.json:

    "build:highlight": "node scripts/build_highlight_alias.js > highlight_alias.json",

It was published in the previous version

@tomap
Copy link
Contributor Author

tomap commented Aug 3, 2019

https://www.npmjs.com/package/hexo-util/v/1.0.0-rc1
(but including the json)

@yoshinorin
Copy link
Member

I and @segayuu want to include #58 to new version of hexo-util.
Would you give us time?

@curbengh
Copy link
Contributor

curbengh commented Aug 4, 2019

Before we do that, I'm wondering if this file
highlight_alias.json
should not be published?

I think the purpose of not publishing it, instead it is dynamically generated is because new version highlight.js might support new languages. Meaning it is possible that highlight.js supports more than the published version highlight_alias.json.

@tomap
Copy link
Contributor Author

tomap commented Aug 4, 2019

I think the purpose of not publishing it, instead it is dynamically generated is because new version highlight.js might support new languages. Meaning it is possible that highlight.js supports more than the published version highlight_alias.json.

Ok, if you're sure, I'll publish next RC without it

@curbengh
Copy link
Contributor

curbengh commented Aug 4, 2019

highlight_alias.json is not generated when I

"hexo-util": "hexojs/hexo-util",

publish next RC without it, I'll test it.

@tomap
Copy link
Contributor Author

tomap commented Aug 7, 2019

I just published RC2
Notice that I dropped the useless changelog.md
and ignored *.tgz

@curbengh I published without highlight_alias.json.

@coveralls
Copy link

coveralls commented Aug 7, 2019

Coverage Status

Coverage remained the same at 95.214% when pulling 05bb2d4 on tomap:bump-version into d63fda6 on hexojs:master.

@curbengh
Copy link
Contributor

curbengh commented Aug 7, 2019

Did you include #67 in RC2?
How did the *.tgz get there?
I think it's fine to publish changelog, even though it's hardly useful in the current state.

Update hexojs/hexo#3646 to include RC2 too.

@curbengh
Copy link
Contributor

curbengh commented Aug 7, 2019

Before we do that, I'm wondering if this file
highlight_alias.json
should not be published?

I think the purpose of not publishing it, instead it is dynamically generated is because new version highlight.js might support new languages. Meaning it is possible that highlight.js supports more than the published version highlight_alias.json.

I just found out the statement is actually outdated. The postinstall step has been replaced by #28 so the build runs during npm publish, not npm install (unless it is executed in ./node_modules/hexo-util).

highlight_alias.json indeed needs to be published, but still remain gitignored.


If I

"hexo-util": "hexojs/hexo-util"

somehow it works, despite there is no highlight_alias.json in the repo. The highlight_alias.json does get generated in ./node_modules/hexo-utl.

My guess is highlight_alias.json is generated on client machine when installed from a git repo, but not generated when installed from npmjs.com.

I'll have more testing on RC2 to confirm this.


PR fix #69

@tomap
Copy link
Contributor Author

tomap commented Aug 10, 2019

I just published RC3: https://www.npmjs.com/package/hexo-util/v/1.0.0-rc3

The tgz comes from my way of creating the npm package:

// to check the content
npm publish --dry-run
// to produce the package as a .tgz
npm pack
// to publish the package 
npm publish hexo-util-1.0.0-rc3.tgz -tag next

@curbengh
Copy link
Contributor

I see, I usually just

npm publish --dry-run
npm publish -tag next

@tomap
Copy link
Contributor Author

tomap commented Aug 11, 2019

I dropped the *.tgz from gitignore and will use your command lines

@tomap
Copy link
Contributor Author

tomap commented Aug 14, 2019

hexojs/hexo#3646 => tests look good
Shall I merge this PR & publish the new version (stable) ?

Copy link
Contributor

@curbengh curbengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versioning

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use npm version instead of pull requests to manually bump the versions.

@curbengh
Copy link
Contributor

I think we should use npm version instead of pull requests to manually bump the versions.

We create PR to notify team members.
https://github.com/orgs/hexojs/teams/core/discussions/5

@tomap
Copy link
Contributor Author

tomap commented Aug 19, 2019

v1 published
https://www.npmjs.com/package/hexo-util/v/1.0.0
Please merge :)

@curbengh curbengh merged commit ddf5813 into hexojs:master Aug 19, 2019
@curbengh curbengh mentioned this pull request Sep 1, 2019
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants