Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring test: es2016nify #46

Merged
merged 1 commit into from Oct 18, 2018
Merged

Refactoring test: es2016nify #46

merged 1 commit into from Oct 18, 2018

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Oct 18, 2018 •
edited

This PR is divided PR because #35 has become big.

@segayuu segayuu requested a review from a team October 18, 2018 02:27
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.866% when pulling 8f87581 on segayuu:Refactoring-test-es2016nify into a1c9e11 on hexojs:master.

yoshinorin
yoshinorin approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoshinorin yoshinorin merged commit 4578651 into hexojs:master Oct 18, 2018
@segayuu segayuu deleted the Refactoring-test-es2016nify branch October 18, 2018 15:07
@segayuu
Copy link
Contributor Author

segayuu commented Oct 18, 2018

thank @yoshinorin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@segayuu @coveralls @yoshinorin