Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring es2016nify #44

Merged
merged 1 commit into from Oct 22, 2018
Merged

Refactoring es2016nify #44

merged 1 commit into from Oct 22, 2018

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Oct 18, 2018

This PR is divided PR because #35 has become big.

@segayuu segayuu requested a review from a team October 18, 2018 01:16
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.657% when pulling ed5cb6e on segayuu:Refactoring-es2016nify into a1c9e11 on hexojs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.657% when pulling ed5cb6e on segayuu:Refactoring-es2016nify into a1c9e11 on hexojs:master.

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yoshinorin yoshinorin merged commit c7cb519 into hexojs:master Oct 22, 2018
@yoshinorin
Copy link
Member

👋 @segayuu

Btw, I need a lot of effort for review that like this pull-request .

At first, a lot of file and code changed.
Second, some different meanings changes include this pull-request.

forexamle

  • var to let/const
  • use defineProperty instead of __define__
  • use allow function

...etc

So, I could have approved more faster, if these changes were divided into some pull requests. 😆

@segayuu segayuu deleted the Refactoring-es2016nify branch October 22, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants