Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate from js to ts #284

Merged
merged 21 commits into from
Nov 11, 2022
Merged

refactor: migrate from js to ts #284

merged 21 commits into from
Nov 11, 2022

Conversation

yoshinorin
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Sep 12, 2022

Coverage Status

Coverage increased (+4.3%) to 95.54% when pulling e28f5d0 on refactor/migrate-to-ts into 282e1e5 on master.

@SukkaW
Copy link
Member

SukkaW commented Sep 12, 2022

@yoshinorin Actually we have a better option.
Currently, @liby is working on porting hexo-util to Rust binding, to have better performance and speed (and first-party typescript typing supports). See https://github.com/liby/hexo-util-rs.

@liby
Copy link
Contributor

liby commented Sep 12, 2022

Hi, @yoshinorin If you're interested, you can take a look under the hexo-util-rs/tree/main/common folder.

This folder contains the following:

  1. Waiting to be RIIR
  2. Has been tried and is not suitable for RIIR

Welcome to your PR.

@yoshinorin
Copy link
Member Author

Sounds interesting!
I will try learning Rust :)

@liby
Copy link
Contributor

liby commented Sep 13, 2022

I will try learning Rust :)

There are actually some other jobs that can be done, For example:

  1. Migrate the .js files in the common folder to .ts, if you think it's necessary.
  2. Improve the test.
  3. Improve type definition.
  4. ...

@stevenjoezhang stevenjoezhang marked this pull request as ready for review November 6, 2022 07:46
@stevenjoezhang stevenjoezhang changed the title [WIP]: refactor: migrate from js to ts refactor: migrate from js to ts Nov 6, 2022
@stevenjoezhang
Copy link
Member

We can merge this pull request first, and then start migrating to rust.

@stevenjoezhang stevenjoezhang requested a review from a team November 6, 2022 07:57
stevenjoezhang
stevenjoezhang previously approved these changes Nov 11, 2022
lib/color.ts Outdated Show resolved Hide resolved
lib/deep_merge.ts Outdated Show resolved Hide resolved
stevenjoezhang and others added 2 commits November 11, 2022 22:52
Co-authored-by: yoshinorin <yoshinorin.net@outlook.com>
@yoshinorin yoshinorin merged commit 67cc431 into master Nov 11, 2022
@yoshinorin yoshinorin deleted the refactor/migrate-to-ts branch November 11, 2022 14:58
@yoshinorin
Copy link
Member Author

@stevenjoezhang
Thank you ❤️
Let's release v3.0.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants