chore: drop Node.js 8 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenjoezhang
previously approved these changes
Apr 21, 2020
|
lgtm, just need to rebase. |
stevenjoezhang
previously approved these changes
Apr 25, 2020
|
@curbengh Done. Minimum required Node.js version is set to 10.3.0 (Tested on my local machine). |
stevenjoezhang
previously approved these changes
Apr 25, 2020
can increase to at least 10.9 just in case we need 10.9+ features, prefer >=10.18 if possible. the rebase somehow doesn't include dropping Node 8 from appveyor, this PR previously did. |
@curbengh As I mentioned in hexojs/hexo#3818 (comment), we could use 10.13.0 instead (which is the first LTS version of Node.js 10) |
curbengh
approved these changes
Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hexojs/hexo#3818