Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: query part of url not preserved across redirects #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: query part of url not preserved across redirects #58

wants to merge 2 commits into from

Conversation

17320
Copy link

@17320 17320 commented Oct 5, 2018

Fixes #57.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 94.69% when pulling 5b077c7 on 17320:57-query-part-of-url-not-preserved-across-redirects into de57a80 on hexojs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 94.69% when pulling 5b077c7 on 17320:57-query-part-of-url-not-preserved-across-redirects into de57a80 on hexojs:master.

tomap
tomap reviewed Feb 27, 2019
View reviewed changes
lib/middlewares/route.js
@@ -2,6 +2,7 @@

var pathFn = require('path');
var mime = require('mime');
var URL = require('url');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowercase please

tomap
tomap approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@tomap tomap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, appart from the URL in upper case => should be lowercase (use urlUtil instead) and the conflict

@stevenjoezhang stevenjoezhang linked an issue Apr 30, 2020 that may be closed by this pull request
Query part of URL is not preserved across redirects #57
Open
@stevenjoezhang stevenjoezhang changed the title 57 query part of url not preserved across redirects fix: query part of url not preserved across redirects May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomap tomap tomap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query part of URL is not preserved across redirects
3 participants
@17320 @coveralls @tomap