Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: specify files in package.json #96

Merged
merged 1 commit into from May 13, 2019
Merged

chore: specify files in package.json #96

merged 1 commit into from May 13, 2019

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented May 10, 2019

Specified files in package.jso and removed outdated .npmignore.

Shrinked our packed size from 4.6KB to 3.6KB.

@JLHwung JLHwung requested review from yoshinorin and a team May 10, 2019 17:41
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.234% when pulling 6759d74 on specify-files into 4e98344 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.234% when pulling 6759d74 on specify-files into 4e98344 on master.

@curbengh
Copy link
Contributor

this also fix npm installation due to existence of .git folder in v1.0.0.
see: shama/napa#53, https://stackoverflow.com/q/27356915

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@yoshinorin yoshinorin merged commit 2859108 into master May 13, 2019
@yoshinorin yoshinorin deleted the specify-files branch May 13, 2019 11:34
@JLHwung
Copy link
Contributor Author

JLHwung commented May 13, 2019

@weyusi Good catch! This fix has landed on 1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants