Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(package): delete object-assign package and use Object.assign instead of it #91

Merged
merged 1 commit into from Apr 13, 2019
Merged

refactor(package): delete object-assign package and use Object.assign instead of it #91

merged 1 commit into from Apr 13, 2019

Conversation

yoshinorin
Copy link
Member

Proposal

Object.assign can use instead of object-assign package.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 87.234% when pulling dbcbd44 on YoshinoriN:drop-object-assign-package into 8ec59ff on hexojs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 87.234% when pulling dbcbd44 on YoshinoriN:drop-object-assign-package into 8ec59ff on hexojs:master.

Copy link
Contributor

@segayuu segayuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! However, Object.assign() can only be used with node.js 4 or higher.
There is no problem if hexo works in node LTS, you only need to specify the node version in package.json :)

@yoshinorin
Copy link
Member Author

Thanks @segayuu & @tomap :)
I made PR about specify node version #92

@segayuu
Copy link
Contributor

segayuu commented Apr 13, 2019

Thank @yoshinorin !

@segayuu segayuu merged commit d6e6afc into hexojs:master Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants