Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use marked.js official heading id implementation #209

Closed
SukkaW opened this issue Sep 25, 2021 · 1 comment · Fixed by #280
Closed

Use marked.js official heading id implementation #209

SukkaW opened this issue Sep 25, 2021 · 1 comment · Fixed by #280

Comments

@SukkaW
Copy link
Member

SukkaW commented Sep 25, 2021

https://github.com/markedjs/marked-gfm-heading-id

Marked.js has an official plugin for that so we should use it instead.

Also, marked.js provides a new way of modifying the renderer's behavior, we should adopt it as well.

cc @jiangtj @stevenjoezhang @hexojs/core

@stevenjoezhang
Copy link
Member

As of marked@5.0.0: headerIds and headerPrefix parameters enabled by default, but are deprecated since version 5.0.0, and will be removed in the future. To clear this warning, install https://www.npmjs.com/package/marked-gfm-heading-id, or disable by setting {headerIds: false}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants