Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable headerIds #106

Merged
merged 3 commits into from Aug 11, 2019
Merged

Add option to disable headerIds #106

merged 3 commits into from Aug 11, 2019

Conversation

tomap
Copy link
Contributor

@tomap tomap commented Aug 2, 2019

(Enabled by default for backward compatibility)
#61

@tomap
Add option to disable headerIds
91acb1b 
(Enabled by default for backward compatibility)
hexojs#61
@tomap
Also update readme
6488b76
@tomap tomap mentioned this pull request Aug 2, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 85.714% when pulling 91acb1b on tomap:feature/disableHeaderIds into 483d99d on hexojs:master.

@coveralls
Copy link

coveralls commented Aug 2, 2019 •
edited

Coverage Status

Coverage increased (+0.7%) to 85.714% when pulling 2fc685e on tomap:feature/disableHeaderIds into 483d99d on hexojs:master.

curbengh
curbengh reviewed Aug 4, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@curbengh
Copy link
Contributor

curbengh commented Aug 4, 2019 •
edited

One last thing before I merge, <a> tag in <h1> requires id attribute to work; if headerIds is disabled, <a> no longer works, so that's why it's not added?

@tomap
Copy link
Contributor Author

tomap commented Aug 11, 2019

yes, indeed, the A without headerids are of no use

@curbengh curbengh merged commit de3f8bc into hexojs:master Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curbengh curbengh curbengh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomap @coveralls @curbengh