Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use nanocolors instead of chalk #56

Merged
merged 1 commit into from
Oct 1, 2021
Merged

refactor: use nanocolors instead of chalk #56

merged 1 commit into from
Oct 1, 2021

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Sep 30, 2021 •
edited

It is faster than chalk, smaller than chalk.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ebdffaf on SukkaW:use-nanocolors into 4159c65 on hexojs:master.

yoshinorin
yoshinorin approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tomap
Copy link
Contributor

tomap commented Sep 30, 2021

Isn't chalk used elsewhere in hero?

@SukkaW
Copy link
Member Author

SukkaW commented Oct 1, 2021 •
edited

Isn't chalk used elsewhere in hexo?

Yeah, I have opened a PR for hexojs/hexo as well. I will check other repo when I have time.

@SukkaW SukkaW merged commit d4add03 into hexojs:master Oct 1, 2021
@stevenjoezhang stevenjoezhang mentioned this pull request Nov 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomap tomap tomap approved these changes

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SukkaW @coveralls @tomap @yoshinorin