New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: throw error on missing key #37

Open

mahnunchik wants to merge 1 commit into hexojs:master from mahnunchik:master

mahnunchik commented Jul 13, 2021 •

edited by uiolee

resolved #36


          chore: throw error on missing key

5b020e6

Member

jiangtj commented Jul 14, 2021

I think this is a breaking change

Some themes rely on the operation of returning the key when i18n does not exist to display content

https://github.com/next-theme/hexo-theme-next/blob/f677a588b2820436a626162e9e71291ce674538c/layout/_partials/header/menu-item.njk#L10

Maybe show a log to inform the user that the current key is not configured with i18n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment