Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index_generator.pagination_dir doesn't take effect #97

Open
6 tasks done
uiolee opened this issue Apr 18, 2024 · 0 comments · May be fixed by #98
Open
6 tasks done

index_generator.pagination_dir doesn't take effect #97

uiolee opened this issue Apr 18, 2024 · 0 comments · May be fixed by #98

Comments

@uiolee
Copy link
Member

uiolee commented Apr 18, 2024

Check List

  • I have already read README.
  • I have already searched existing issues and they are not help to me.
  • I examined error or warning messages and it's difficult to solve.
  • I am using the latest version of this repository.
  • I am using the latest version of Hexo.
  • My Node.js is matched the required version.

Describe the bug

``` yaml
index_generator:
path: ''
per_page: 10
order_by: -date
pagination_dir: page
```

according to README, pagination_dir can be set by index_generator.pagination_dir.
But from the code, index_generator.pagination_dir is invalid.

const paginationDir = config.pagination_dir || 'page';

Expected behavior

Code and documentation should match, avoid misleading users.

How to reproduce

Screenshots

No response

Environment information

No response

Additional context

No response

@uiolee uiolee linked a pull request Apr 18, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant