Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable comments or make it customizable #154

Open
jiangtj opened this issue Aug 10, 2020 · 3 comments
Open

Disable comments or make it customizable #154

jiangtj opened this issue Aug 10, 2020 · 3 comments

Comments

@jiangtj
Copy link
Member

jiangtj commented Aug 10, 2020

{% if post.comments %}
<comments>{{ post.permalink | uriencode }}#disqus_thread</comments>
{% endif %}

If post.comment is true, it will set disqus comment uri, but it is not all people use disqus.

I think it's better to disable comments or make it customizable

@tomap
Copy link
Contributor

tomap commented Aug 15, 2020

Hi,

It seems to be a legitimate request.
What kind of comments are you using ?
Would it be enough to make the "#disqus_thread" customizable ?

@SukkaW
Copy link
Member

SukkaW commented Aug 15, 2020

FYI, Hexo never add comment nor comments during processing. Thus in most case the comment won't exist.

@jiangtj
Copy link
Member Author

jiangtj commented Aug 17, 2020

FYI, Hexo never add comment nor comments during processing. Thus in most case the comment won't exist.

By default, comments is true
https://github.com/hexojs/hexo/blob/2dfaa6a600594ed5d087da683d67b7bc83fd2646/lib/models/page.js#L23

What kind of comments are you using ?

disqus 😂 , this problem didn't affect me, I just found it by accident

Would it be enough to make the "#disqus_thread" customizable ?

Maybe add another page variable, e.g. comments_url?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants