Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use hexo-util built-in escape-regexp #56

Merged
merged 1 commit into from Mar 6, 2020
Merged

refactor: use hexo-util built-in escape-regexp #56

merged 1 commit into from Mar 6, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Mar 4, 2020

No description provided.

@SukkaW SukkaW requested review from segayuu and a team March 4, 2020 06:21
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.321% when pulling f2f7417 on SukkaW:avoid-extra-dependencies into 336747f on hexojs:master.

stevenjoezhang
stevenjoezhang reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@stevenjoezhang stevenjoezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these two modules are slightly different

https://github.com/hexojs/hexo-util/blob/e81733cd2e4ebde9c7b2f3d22bdc82763fd0b398/lib/escape_regexp.js#L7
https://github.com/sindresorhus/escape-string-regexp/blob/5085b257c801507460270b747f645276fbc1d937/index.js#L3

@SukkaW SukkaW requested a review from curbengh March 4, 2020 10:23
@curbengh
Copy link
Contributor

curbengh commented Mar 5, 2020

It looks like these two modules are slightly different

hexo-util escapes forward slash /, which I believe is to escape the literal notation /pattern/i.

curbengh
curbengh approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@curbengh curbengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hexo-util's escapeRegExp has been used in production.

@SukkaW SukkaW merged commit 936ef7d into hexojs:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

@curbengh curbengh curbengh approved these changes

@segayuu segayuu Awaiting requested review from segayuu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SukkaW @coveralls @curbengh @stevenjoezhang