Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaction to fs.promises API #47

Open
segayuu opened this issue Nov 5, 2019 · 0 comments
Open

Reaction to fs.promises API #47

segayuu opened this issue Nov 5, 2019 · 0 comments

Comments

@segayuu
Copy link
Contributor

segayuu commented Nov 5, 2019

Node.js made fs.promises API stable when version12 became LTS. Since it is backported to v10 at the same time, fs.promises can be used stably in v10, v12, and v13.
The bluebird library authors recommend using bluebird only around the year "when you need more performance than collection methods and asynchronous features" around 2017.
Most hexo-fs features are now available with the fs.promises API.
I think we are forced to make a choice regarding the policy of this package.

  • Maintaining compatibility
  • Reimplement based on fs.promises API
  • Encourage package users to move to fs.promises

Or there may be other options, and there may be a compromise.
However, there are some implementations such as fs.Direct that run faster than the implementation of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant