Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "noreferrer" configurable #8

Open
bennycode opened this issue May 25, 2020 · 3 comments 路 May be fixed by #9 or #14
Open

Make "noreferrer" configurable #8

bennycode opened this issue May 25, 2020 · 3 comments 路 May be fixed by #9 or #14

Comments

@bennycode
Copy link

Thanks for sharing this great plugin with the community! 馃憫

By default it sets a "noreferrer" attribute but I would like to send the referrering site when opening external sites. Is there any chance to configure this option through the _config.yml?

@john850512
Copy link

I have the same issue.
Currently, I thought it can be done by modifying the source code below: lib/filter.js

which the noFollow config is

let noFollow = ['noopener', 'external', 'nofollow', 'noreferrer'];

and you can change to

let noFollow = ['noopener', 'external', 'nofollow', ];

to make noreferrer attribute disappear.

However, it is helpful if someone can send a PR that makes this configurable.

@bennycode
Copy link
Author

PR will be easy. Question is if @SukkaW or @curbengh have the permissions to merge such PR?

@SukkaW
Copy link
Member

SukkaW commented Jun 5, 2020

@bennyn The PR will be welcome. However we might not release a newer version including this feature very soon.

@curbengh curbengh linked a pull request Jul 24, 2020 that will close this issue
@holmofy holmofy linked a pull request May 28, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants