Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use luxon instead of moment #204

Merged
merged 1 commit into from Jan 29, 2022
Merged

Use luxon instead of moment #204

merged 1 commit into from Jan 29, 2022

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Jun 3, 2021

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevenjoezhang

Basically, I agree with using other libraries instead of the moment.
But, why luxon?

https://momentjs.com/docs/#/-project-status/recommendations/

I'm not sure, but it seems date-fns or dayjs are better than luxon according to the below doc.

https://github.com/you-dont-need/You-Dont-Need-Momentjs

How do you think?
In any case, I agree with drop the moment also from all of the hexo repositories.

@stevenjoezhang
Copy link
Member Author

drop the moment also from all of the hexo repositories.

Yes, actually we can start with Hexo first. But the migration work will be very tricky, because moment is imported in more than 100 script files of Hexo.

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevenjoezhang
Would you please resolve conflict?
I'm going to approve this.

Thank you :)

@stevenjoezhang
Copy link
Member Author

Done, I have rebased the head branch on master

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@yoshinorin yoshinorin merged commit 7d93124 into master Jan 29, 2022
@yoshinorin yoshinorin deleted the luxon branch January 29, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants