From 67999b0ea2ea81d2886036ad6bd696acdbb0efb7 Mon Sep 17 00:00:00 2001 From: segayuu Date: Tue, 17 Apr 2018 09:35:57 +0900 Subject: [PATCH 1/7] Organize changes made from recommended config --- eslint.js | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/eslint.js b/eslint.js index fd51b0e..b1117ee 100644 --- a/eslint.js +++ b/eslint.js @@ -2,8 +2,12 @@ module.exports = { extends: ['eslint:recommended', 'plugin:node/recommended'], plugins: ['node'], rules: { - 'curly': ['error', 'multi-line'], + // override recomennded 'no-console': 'off', + 'no-empty': ['error', { allowEmptyCatch: true }], + 'no-unused-vars': ['error', { args: 'none' }], + // end override recomennded + 'curly': ['error', 'multi-line'], 'no-path-concat': 'error', 'handle-callback-err': 'error', 'no-use-before-define': ['error', 'nofunc'], @@ -20,7 +24,6 @@ module.exports = { 'no-multi-spaces': 'error', 'no-multi-str': 'error', 'no-new-wrappers': 'error', - 'no-redeclare': 'error', 'no-return-assign': 'error', 'no-throw-literal': 'error', 'no-unused-expressions': ['error', { @@ -32,23 +35,15 @@ module.exports = { 'no-with': 'error', 'radix': 'error', 'no-self-compare': 'error', - 'no-unused-vars': ['error', { - vars: 'all', - args: 'none' - }], 'indent': ['error', 2, { SwitchCase: 1 }], 'linebreak-style': ['error', 'unix'], 'quotes': ['error', 'single'], 'semi': ['error', 'always'], - 'no-empty': ['error', { - allowEmptyCatch: true - }], 'brace-style': ['error', '1tbs', { allowSingleLine: true }], - 'no-mixed-spaces-and-tabs': 'error', 'no-multiple-empty-lines': 'error', 'no-multi-str': 'error', 'one-var': ['error', { @@ -91,9 +86,7 @@ module.exports = { returnAssign: false, nestedBinaryExpressions: false }], - 'no-unsafe-negation': 'error', 'array-callback-return': 'error', - 'no-empty-pattern': 'error', 'no-eval': 'error', 'no-extra-label': 'error', 'no-implicit-globals': 'error', From 6383a2069a0c272df9b0f2cc01f44c3679ab944b Mon Sep 17 00:00:00 2001 From: segayuu Date: Tue, 17 Apr 2018 10:19:17 +0900 Subject: [PATCH 2/7] [WIP] Category Sort: Possible Errors & Best Practices & Strict Mode --- eslint.js | 66 +++++++++++++++++++++++++++++-------------------------- 1 file changed, 35 insertions(+), 31 deletions(-) diff --git a/eslint.js b/eslint.js index b1117ee..1d09852 100644 --- a/eslint.js +++ b/eslint.js @@ -6,25 +6,34 @@ module.exports = { 'no-console': 'off', 'no-empty': ['error', { allowEmptyCatch: true }], 'no-unused-vars': ['error', { args: 'none' }], - // end override recomennded - 'curly': ['error', 'multi-line'], - 'no-path-concat': 'error', - 'handle-callback-err': 'error', - 'no-use-before-define': ['error', 'nofunc'], - 'no-shadow-restricted-names': 'error', + // Possible Errors + 'no-extra-parens': ['error', 'all', { + conditionalAssign: false, + returnAssign: false, + nestedBinaryExpressions: false + }], + // Best Practices + 'array-callback-return': 'error', 'block-scoped-var': 'error', + 'curly': ['error', 'multi-line'], + 'dot-location': ['error', 'property'], 'dot-notation': 'error', 'eqeqeq': ['error', 'allow-null'], 'no-else-return': 'error', + 'no-eval': 'error', 'no-extend-native': 'error', 'no-extra-bind': 'error', + 'no-implicit-globals': 'error', 'no-implied-eval': 'error', 'no-lone-blocks': 'error', 'no-loop-func': 'error', 'no-multi-spaces': 'error', 'no-multi-str': 'error', + 'no-new': 'error', + 'no-new-func': 'error', 'no-new-wrappers': 'error', - 'no-return-assign': 'error', + 'no-self-compare': 'error', + 'no-sequences': 'error', 'no-throw-literal': 'error', 'no-unused-expressions': ['error', { allowShortCircuit: true, @@ -32,9 +41,26 @@ module.exports = { }], 'no-useless-call': 'error', 'no-useless-concat': 'error', + 'no-useless-return': 'error', + 'no-proto': 'error', + 'no-return-assign': 'error', + 'no-void': 'error', 'no-with': 'error', + 'prefer-promise-reject-errors': 'error', 'radix': 'error', - 'no-self-compare': 'error', + 'wrap-iife': 'error', + 'yoda': ['error', 'never'], + // Strict Mode + 'strict': 'error', + // Variables + 'no-shadow-restricted-names': 'error', + 'no-use-before-define': ['error', 'nofunc'], + // Node.js and CommonJS + 'handle-callback-err': 'error', + // Stylistic Issues + 'no-path-concat': 'error', + // ECMAScript 6 + // other 'indent': ['error', 2, { SwitchCase: 1 }], @@ -45,12 +71,10 @@ module.exports = { allowSingleLine: true }], 'no-multiple-empty-lines': 'error', - 'no-multi-str': 'error', 'one-var': ['error', { uninitialized: 'always', initialized: 'never' }], - 'dot-location': ['error', 'property'], 'operator-linebreak': ['error', 'before'], 'key-spacing': ['error', { beforeColon: false, @@ -73,31 +97,12 @@ module.exports = { 'space-in-parens': ['error', 'never'], 'comma-dangle': ['error', 'never'], 'no-trailing-spaces': 'error', - 'yoda': ['error', 'never'], 'comma-style': ['error', 'last'], - 'dot-notation': 'error', 'eol-last': 'error', - 'wrap-iife': 'error', 'space-infix-ops': 'error', 'keyword-spacing': ['error', {}], 'space-before-blocks': ['error', 'always'], - 'no-extra-parens': ['error', 'all', { - conditionalAssign: false, - returnAssign: false, - nestedBinaryExpressions: false - }], - 'array-callback-return': 'error', - 'no-eval': 'error', 'no-extra-label': 'error', - 'no-implicit-globals': 'error', - 'no-new-func': 'error', - 'no-new': 'error', - 'no-proto': 'error', - 'no-sequences': 'error', - 'no-useless-escape': 'error', - 'no-useless-return': 'error', - 'no-void': 'error', - 'prefer-promise-reject-errors': 'error', 'no-label-var': 'error', 'no-undef-init': 'error', 'array-bracket-spacing': ['error', 'never'], @@ -128,8 +133,7 @@ module.exports = { 'rest-spread-spacing': ['error', 'never'], 'template-curly-spacing': ['error', 'never'], 'yield-star-spacing': ['error', 'after'], - 'no-mixed-operators': 'error', - 'strict': 'error' + 'no-mixed-operators': 'error' }, env: { node: true, From b4e48f44fd2237f597f64ebb5a4a2fdf59009a90 Mon Sep 17 00:00:00 2001 From: segayuu Date: Tue, 17 Apr 2018 10:22:49 +0900 Subject: [PATCH 3/7] [WIP] Category Sort: Variables --- eslint.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eslint.js b/eslint.js index 1d09852..2545d70 100644 --- a/eslint.js +++ b/eslint.js @@ -53,7 +53,9 @@ module.exports = { // Strict Mode 'strict': 'error', // Variables + 'no-label-var': 'error', 'no-shadow-restricted-names': 'error', + 'no-undef-init': 'error', 'no-use-before-define': ['error', 'nofunc'], // Node.js and CommonJS 'handle-callback-err': 'error', @@ -103,8 +105,6 @@ module.exports = { 'keyword-spacing': ['error', {}], 'space-before-blocks': ['error', 'always'], 'no-extra-label': 'error', - 'no-label-var': 'error', - 'no-undef-init': 'error', 'array-bracket-spacing': ['error', 'never'], 'computed-property-spacing': ['error', 'never'], 'block-spacing': ['error', 'always'], From e17caefdbe9765d0122f010dd5ebcbc81db013eb Mon Sep 17 00:00:00 2001 From: segayuu Date: Tue, 17 Apr 2018 10:25:44 +0900 Subject: [PATCH 4/7] [WIP] Category Sort: Node.js and CommonJS --- eslint.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/eslint.js b/eslint.js index 2545d70..727997b 100644 --- a/eslint.js +++ b/eslint.js @@ -59,8 +59,9 @@ module.exports = { 'no-use-before-define': ['error', 'nofunc'], // Node.js and CommonJS 'handle-callback-err': 'error', - // Stylistic Issues + 'no-mixed-operators': 'error', 'no-path-concat': 'error', + // Stylistic Issues // ECMAScript 6 // other 'indent': ['error', 2, { @@ -132,8 +133,7 @@ module.exports = { 'no-useless-rename': 'error', 'rest-spread-spacing': ['error', 'never'], 'template-curly-spacing': ['error', 'never'], - 'yield-star-spacing': ['error', 'after'], - 'no-mixed-operators': 'error' + 'yield-star-spacing': ['error', 'after'] }, env: { node: true, From fb47e5d9ddeb5ea9b22a4915cae4e2000662c2b2 Mon Sep 17 00:00:00 2001 From: segayuu Date: Tue, 17 Apr 2018 10:31:20 +0900 Subject: [PATCH 5/7] [WIP]: Category Sort: ECMAScript 6 --- eslint.js | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/eslint.js b/eslint.js index 727997b..c3ca856 100644 --- a/eslint.js +++ b/eslint.js @@ -63,6 +63,18 @@ module.exports = { 'no-path-concat': 'error', // Stylistic Issues // ECMAScript 6 + 'arrow-spacing': 'error', + 'generator-star-spacing': ['error', 'after'], + 'no-confusing-arrow': ['error', { + allowParens: true + }], + 'no-duplicate-imports': 'error', + 'no-useless-computed-key': 'error', + 'no-useless-constructor': 'error', + 'no-useless-rename': 'error', + 'rest-spread-spacing': ['error', 'never'], + 'template-curly-spacing': ['error', 'never'], + 'yield-star-spacing': ['error', 'after'], // other 'indent': ['error', 2, { SwitchCase: 1 @@ -121,19 +133,7 @@ module.exports = { 'no-whitespace-before-property': 'error', 'spaced-comment': ['error', 'always'], 'template-tag-spacing': ['error', 'never'], - 'unicode-bom': ['error', 'never'], - 'arrow-spacing': 'error', - 'generator-star-spacing': ['error', 'after'], - 'no-confusing-arrow': ['error', { - allowParens: true - }], - 'no-duplicate-imports': 'error', - 'no-useless-computed-key': 'error', - 'no-useless-constructor': 'error', - 'no-useless-rename': 'error', - 'rest-spread-spacing': ['error', 'never'], - 'template-curly-spacing': ['error', 'never'], - 'yield-star-spacing': ['error', 'after'] + 'unicode-bom': ['error', 'never'] }, env: { node: true, From 773054ac29087cc365f583c94ea1c4a7dd81ae9b Mon Sep 17 00:00:00 2001 From: segayuu Date: Tue, 17 Apr 2018 10:36:31 +0900 Subject: [PATCH 6/7] [WIP] format & Category Sort --- eslint.js | 39 +++++++++++++++------------------------ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/eslint.js b/eslint.js index c3ca856..6a44377 100644 --- a/eslint.js +++ b/eslint.js @@ -62,29 +62,11 @@ module.exports = { 'no-mixed-operators': 'error', 'no-path-concat': 'error', // Stylistic Issues - // ECMAScript 6 - 'arrow-spacing': 'error', - 'generator-star-spacing': ['error', 'after'], - 'no-confusing-arrow': ['error', { - allowParens: true - }], - 'no-duplicate-imports': 'error', - 'no-useless-computed-key': 'error', - 'no-useless-constructor': 'error', - 'no-useless-rename': 'error', - 'rest-spread-spacing': ['error', 'never'], - 'template-curly-spacing': ['error', 'never'], - 'yield-star-spacing': ['error', 'after'], - // other - 'indent': ['error', 2, { - SwitchCase: 1 - }], + 'indent': ['error', 2, { SwitchCase: 1 }], 'linebreak-style': ['error', 'unix'], 'quotes': ['error', 'single'], 'semi': ['error', 'always'], - 'brace-style': ['error', '1tbs', { - allowSingleLine: true - }], + 'brace-style': ['error', '1tbs', { allowSingleLine: true }], 'no-multiple-empty-lines': 'error', 'one-var': ['error', { uninitialized: 'always', @@ -121,9 +103,7 @@ module.exports = { 'array-bracket-spacing': ['error', 'never'], 'computed-property-spacing': ['error', 'never'], 'block-spacing': ['error', 'always'], - 'lines-around-comment': ['error', { - beforeBlockComment: true - }], + 'lines-around-comment': ['error', { beforeBlockComment: true }], 'new-cap': 'error', 'new-parens': 'error', 'no-array-constructor': 'error', @@ -133,7 +113,18 @@ module.exports = { 'no-whitespace-before-property': 'error', 'spaced-comment': ['error', 'always'], 'template-tag-spacing': ['error', 'never'], - 'unicode-bom': ['error', 'never'] + 'unicode-bom': ['error', 'never'], + // ECMAScript 6 + 'arrow-spacing': 'error', + 'generator-star-spacing': ['error', 'after'], + 'no-confusing-arrow': ['error', { allowParens: true }], + 'no-duplicate-imports': 'error', + 'no-useless-computed-key': 'error', + 'no-useless-constructor': 'error', + 'no-useless-rename': 'error', + 'rest-spread-spacing': ['error', 'never'], + 'template-curly-spacing': ['error', 'never'], + 'yield-star-spacing': ['error', 'after'] }, env: { node: true, From 33c420f8b113da534d5c5b2416200f3f90c613f3 Mon Sep 17 00:00:00 2001 From: segayuu Date: Tue, 17 Apr 2018 10:49:29 +0900 Subject: [PATCH 7/7] [WIP]: Category Stylistic Issues Sort --- eslint.js | 66 +++++++++++++++++++++++++++---------------------------- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/eslint.js b/eslint.js index 6a44377..8ab24f2 100644 --- a/eslint.js +++ b/eslint.js @@ -62,55 +62,55 @@ module.exports = { 'no-mixed-operators': 'error', 'no-path-concat': 'error', // Stylistic Issues - 'indent': ['error', 2, { SwitchCase: 1 }], - 'linebreak-style': ['error', 'unix'], - 'quotes': ['error', 'single'], - 'semi': ['error', 'always'], + 'array-bracket-spacing': ['error', 'never'], + 'block-spacing': ['error', 'always'], 'brace-style': ['error', '1tbs', { allowSingleLine: true }], - 'no-multiple-empty-lines': 'error', - 'one-var': ['error', { - uninitialized: 'always', - initialized: 'never' - }], - 'operator-linebreak': ['error', 'before'], - 'key-spacing': ['error', { - beforeColon: false, - afterColon: true - }], - 'space-unary-ops': ['error', { - words: false, - nonwords: false - }], + 'comma-dangle': ['error', 'never'], 'comma-spacing': ['error', { before: false, after: true }], - 'semi-spacing': ['error', { - before: false, - after: true - }], - 'func-call-spacing': 'error', - 'space-before-function-paren': ['error', 'never'], - 'space-in-parens': ['error', 'never'], - 'comma-dangle': ['error', 'never'], - 'no-trailing-spaces': 'error', 'comma-style': ['error', 'last'], + 'computed-property-spacing': ['error', 'never'], 'eol-last': 'error', - 'space-infix-ops': 'error', + 'func-call-spacing': 'error', + 'indent': ['error', 2, { SwitchCase: 1 }], + 'key-spacing': ['error', { + beforeColon: false, + afterColon: true + }], 'keyword-spacing': ['error', {}], - 'space-before-blocks': ['error', 'always'], - 'no-extra-label': 'error', - 'array-bracket-spacing': ['error', 'never'], - 'computed-property-spacing': ['error', 'never'], - 'block-spacing': ['error', 'always'], + 'linebreak-style': ['error', 'unix'], 'lines-around-comment': ['error', { beforeBlockComment: true }], 'new-cap': 'error', 'new-parens': 'error', 'no-array-constructor': 'error', + 'no-extra-label': 'error', + 'no-multiple-empty-lines': 'error', 'no-nested-ternary': 'error', 'no-new-object': 'error', + 'no-trailing-spaces': 'error', 'no-unneeded-ternary': 'error', 'no-whitespace-before-property': 'error', + 'one-var': ['error', { + uninitialized: 'always', + initialized: 'never' + }], + 'operator-linebreak': ['error', 'before'], + 'quotes': ['error', 'single'], + 'semi': ['error', 'always'], + 'semi-spacing': ['error', { + before: false, + after: true + }], + 'space-before-blocks': ['error', 'always'], + 'space-before-function-paren': ['error', 'never'], + 'space-in-parens': ['error', 'never'], + 'space-infix-ops': 'error', + 'space-unary-ops': ['error', { + words: false, + nonwords: false + }], 'spaced-comment': ['error', 'always'], 'template-tag-spacing': ['error', 'never'], 'unicode-bom': ['error', 'never'],