Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: whatwg url api is not supported by node 8 #19

Merged
merged 1 commit into from Aug 21, 2019
Merged

fix: whatwg url api is not supported by node 8 #19

merged 1 commit into from Aug 21, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Aug 18, 2019 •
edited

When using the master branch, test with hexo-generator-feed yields the following error:

'url.parse' was deprecated since v11.0.0. Use 'url.URL' constructor instead  node/no-deprecated-api

old URL API is required for Node 8 compatibility, Node 8 doesn't support the new URL API.

@curbengh curbengh requested a review from a team August 18, 2019 03:34
@curbengh curbengh mentioned this pull request Aug 18, 2019
Closed
@tomap tomap merged commit 91b9bdf into hexojs:master Aug 21, 2019
@curbengh curbengh deleted the node-8-url branch August 21, 2019 08:30
@curbengh curbengh mentioned this pull request Oct 22, 2019
Merged
@curbengh
Copy link
Contributor Author

@hexojs/core
WHATWG URL API is actually introduced back in Node 7, so Node 8 does support it. However, I suggest to keep this commit until we drop Node 8. The reason being the API implementation in Node 8 is considered incomplete, thus could not serve as a drop-in replacement (see hexojs/hexo-util#114).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomap tomap tomap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@curbengh @tomap