fix(server): migration to explicit primary IPs fails #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When migrating a server from the previously used implicit primary IPs to using the `hcloud_primary_ip` resources and specifying those in the `hcloud_server.public_net` argument failed, because the state for the `public_net` was not correctly populated. This caused the servers to require an unnecessary re-attach of the primary ips. Fixes #577
|
This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs. |
|
Closing as I have not managed to fix the bugs that came with my changes. This will be easier to implement after #752 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating a server from the previously used implicit primary IPs to using the
hcloud_primary_ipresources and specifying those in thehcloud_server.public_netargument failed, because the state for thepublic_netwas not correctly populated. This caused the servers to require an unnecessary re-attach of the primary ips.Fixes #577