Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package version from hcloud.__version__.VERSION to hcloud.__version__ #234

Open
jooola opened this issue Jul 5, 2023 · 2 comments
Open
Labels
enhancement New feature or request pinned
Milestone

Comments

@jooola
Copy link
Member

jooola commented Jul 5, 2023

Feature Request

Is your feature request related to a problem? Please describe.

The package version is currently stored in hcloud.__version__.VERSION: in the hcloud.__version__ module inside a VERSION constant.

To simplify access to the version, I propose to move and rename the VERSION constant (or reexport it) inside the hcloud/__init__.py file, so we can directly access it with hcloud.__version__.

In addition, once we only support python 3.8, we could also use the importlib.metadata standard library to fetch the version from the package metadata.

@jooola jooola added this to the v2.0.0 milestone Jul 5, 2023
@jooola jooola added the enhancement New feature or request label Jul 18, 2023
@github-actions
Copy link

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

@github-actions github-actions bot added the Stale label Oct 16, 2023
@jooola jooola removed the Stale label Oct 17, 2023
Copy link

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

@github-actions github-actions bot added the Stale label Jan 16, 2024
@jooola jooola added pinned and removed Stale labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned
Projects
None yet
Development

No branches or pull requests

1 participant