Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency resolution fails due to unnecessary upper bound #155

Closed
justinmayer opened this issue May 3, 2022 · 5 comments · Fixed by #163
Closed

Dependency resolution fails due to unnecessary upper bound #155

justinmayer opened this issue May 3, 2022 · 5 comments · Fixed by #163
Labels

Comments

@justinmayer
Copy link

justinmayer commented May 3, 2022

Bug Report

Current Behavior

If you have a project that specifies Python in its pyproject.toml file like so:

[tool.poetry.dependencies]
python = ">=3.10,<4.0"

… and then try to add Hcloud-Python as a dependency:

poetry add hcloud

… dependency resolution will fail:

The current project's Python requirement (>=3.10,<4.0) is not compatible with some of the required packages Python requirement:

  • hcloud requires Python !=3.0., !=3.1., !=3.2., !=3.3., !=3.4.*, <3.11, so it will not be satisfied for Python >=3.11,<4.0

Because hcloud (1.17.0) requires Python !=3.0., !=3.1., !=3.2., !=3.3., !=3.4.*, <3.11
and no versions of hcloud match >1.17.0,<2.0.0, hcloud is forbidden.
So, because fortressa depends on hcloud (^1.17.0), version solving failed.

Expected behavior/code

The expected behavior is that dependency resolution would not fail.

Environment

  • Python Version: v3.10.5
  • Hcloud-Python Version: v1.17.0
  • Poetry 1.2.0b3

Possible Solution

The best way to address this problem is most likely to remove the upper bound from the relevant line in setup.py.

As was noted when the Black project dropped upper bounds:

"[Upper bounds] mostly cause unnecessary trouble."

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

@github-actions github-actions bot added the Stale label Aug 2, 2022
@justinmayer
Copy link
Author

This issue is still present and relevant, which I have just confirmed on the latest Hcloud-Python v1.17.0 release. I have correspondingly updated the issue description to account for these details.

@LKaemmerling: Would you be so kind as to consider addressing this issue in the next Hcloud-Python release?

@LKaemmerling
Copy link
Member

Hey @justinmayer,

will be fixed with the next release :)

@justinmayer
Copy link
Author

Much appreciated, Lukas. I look forward to those enhancements landing in a published release soon. ✨

@justinmayer
Copy link
Author

I confirmed that v1.18.0 addresses this issue. Once again, thank you for the prompt attention. 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants