fix: error when updating IPv6 Primary IP #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API returns a CIDR range in the `ip` field for ipv6 primary IPs. This
caused the `PrimaryIPClient.Update` call to fail, because the response
was parsed as a `net.IP`, but should have been parsed using `net.ParseNetwork`.
The required logic was already implemented in the `PrimaryIPFromSchema`
function, but not used for the update call.
With this commit, the struct `hcloud.PrimaryIPUpdateResult` is removed,
because using it to parse the response causes the error and it was never
returned from any of our methods, so consumers should not be using it.
This error was originally found in hcloud-cli, and caused following error
message:
➜ ~ hcloud primary-ip update --auto-delete=false test-ip
hcloud: updating Primary IP test-ip failed: invalid IP address: 2001:db8::/64
apricote
force-pushed
the
fix-primary-ip-v6-update
branch
from
7501b60
to
532d840
Compare
LKaemmerling
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API returns a CIDR range in the
ipfield for ipv6 primary IPs. This caused thePrimaryIPClient.Updatecall to fail, because the response was parsed as anet.IP, but should have been parsed usingnet.ParseNetwork.The required logic was already implemented in the
PrimaryIPFromSchemafunction, but not used for the update call.With this commit, the struct
hcloud.PrimaryIPUpdateResultis removed, because using it to parse the response causes the error and it was never returned from any of our methods, so consumers should not be using it.This error was originally found in hcloud-cli, and caused following error message: