Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema for primary IP pricing to reflect the current API response #222

Merged
merged 1 commit into from Dec 28, 2022

Conversation

byReqz
Copy link
Contributor

@byReqz byReqz commented Dec 25, 2022

The /pricing API endpoint for primary IPs does not return individual DCs anymore but just regions ("fsn1", "nbg1", ...). I have changed the key name in the schema and updated the test for the new format.

@apricote
Copy link
Member

Looks like we changed the API after implementing it in hcloud-go. I will try to make sure that such things do not happen in the future.

@apricote
Copy link
Member

Thanks for the fix @byReqz!

@jangraefen
Copy link

Hey @apricote,

are you planning on releasing the fix in the near future or are you guys waiting for other things? In case the release will take some time, I am considering disabling the primary IP address future from my Prometheus exporter for now, to prevent any further crashes or issues for my users. If a release is imminent though, I think a temorary release for the Prometheus exporter would be overkill though 😉.

With kind regards,
Jan

@apricote
Copy link
Member

I can publish a release tomorrow :)

@jangraefen
Copy link

@apricote: Wow, thats a quick response and a nice one at that! Thanks for being so quick and for the good work! 🙂

@apricote
Copy link
Member

@jangraefen Release v1.39.0 is published with these changes. https://github.com/hetznercloud/hcloud-go/releases/tag/v1.39.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants