You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Emit Warning event when we mark a Node for removal because the Node.Name does not match RobotServer.Name
Expected behavior
We recently introduced Kubernetes Events in #598. I tried to identify all code-paths that should emit a warning, but missed this one. Based on the actions taken after this code path (Node is removed from cluster) I think this warrants an event to make understanding this easier for cluster operators.
TL;DR
Emit Warning event when we mark a Node for removal because the
Node.Name
does not matchRobotServer.Name
Expected behavior
We recently introduced Kubernetes Events in #598. I tried to identify all code-paths that should emit a warning, but missed this one. Based on the actions taken after this code path (Node is removed from cluster) I think this warrants an event to make understanding this easier for cluster operators.
hcloud-cloud-controller-manager/hcloud/instances_util.go
Lines 92 to 95 in 2f339d2
The text was updated successfully, but these errors were encountered: