Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Event when Robot Node is removed because name changed #606

Open
apricote opened this issue Jan 15, 2024 · 1 comment
Open

feat: Event when Robot Node is removed because name changed #606

apricote opened this issue Jan 15, 2024 · 1 comment
Labels
enhancement New feature or request pinned

Comments

@apricote
Copy link
Member

TL;DR

Emit Warning event when we mark a Node for removal because the Node.Name does not match RobotServer.Name

Expected behavior

We recently introduced Kubernetes Events in #598. I tried to identify all code-paths that should emit a warning, but missed this one. Based on the actions taken after this code path (Node is removed from cluster) I think this warrants an event to make understanding this easier for cluster operators.

// check whether name matches - otherwise this server does not belong to the respective node anymore
if server.Name != node.Name {
return nil, nil
}

@apricote apricote added the enhancement New feature or request label Jan 15, 2024
Copy link
Contributor

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

@github-actions github-actions bot added the stale label Apr 14, 2024
@apricote apricote added pinned and removed stale labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned
Projects
None yet
Development

No branches or pull requests

1 participant