Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(robot): Support Private Networks & Routing #571

Closed
jahanson opened this issue Nov 29, 2023 · 5 comments
Closed

feat(robot): Support Private Networks & Routing #571

jahanson opened this issue Nov 29, 2023 · 5 comments
Labels
enhancement New feature or request stale

Comments

@jahanson
Copy link

When hccm tries to provision and add the server meta data it tries to match the IPs. In my case the main IP is private but as previously stated in a few different issues the robot client can't retrieve vswitch/private IPs so it ultimately fails and ignores provisioning the server metadata even though the hostnames match on robot and on the node.

Screenshot from 2023-11-29 14-42-17

Is there any way we can ignore the ip matching on robot since the hostname matching is usually enough?

@apricote
Copy link
Member

Hey @jahanson,

are you using https://github.com/syself/hetzner-cloud-controller-manager or the unreleased Robot support from this repository?

For the initial version, we will not support using private IPs in clusters with Robot Servers, precisely because we can not get the private IP. The code that fails in your logs is from an official kubernetes library (https://github.com/kubernetes/cloud-provider), so there anything we could do here would be a workaround.

Once we have the initial support released, we can start planning on enabling private networks/vSwitches/Routes. One idea I have right now, would be to let the user set a Node Label for the Private IPs

@apricote apricote added the enhancement New feature or request label Nov 30, 2023
@jahanson
Copy link
Author

Hey @apricote, I am using the unreleased Robot support from this repo. I am currently using cilium between all nodes so disabling the networking function for hccm is no problem. I didn't know however that the logs I provided were from kubernetes/cloud-provider.

Setting a node label for private ips would be great. I appreciate your work on this! If there's anything I can do to help let me know

@apricote
Copy link
Member

Great to hear that you are using it already!

The code that fails for you is here: https://github.com/kubernetes/cloud-provider/blob/152995bd25ae20bc618a9ba7039a1b683372c86c/node/helpers/address.go#L131-L134

I plan on talking to the team responsible for Networks next week, to discuss how well we can integrate it. I can not yet promise anything, and it will probably not be included in the next release (planned for the coming week).

@apricote apricote changed the title option to ignore ip mismatch feat(robot): Support Private Networks & Routing Dec 7, 2023
@apricote
Copy link
Member

Right now it is not possible to configure Routes using vSwitch IPs as Gateway. This is a strict requirement for enabling the Routes functionality.

Copy link
Contributor

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

@github-actions github-actions bot added the stale label Apr 24, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants