fix(deployment): remove dns-policy #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Ran the e2e tests locally, all looking good :) Thanks for the fix @simonostendorf!
|
This has caused a regression in our dev/test system for Deployments not using the Network Routes (#561):
I am going to revert this for now to (finally) get #561 in, then we can take another look at how we can improve the situation for your sidecars. |
apricote
added a commit
that referenced
this pull request
Nov 21, 2023
This reverts commit 2c83786. The commit caused a regression where clusters not using the host network were unable to bootstrap successfully: - CoreDNS did not start because the Node was still tainted as uninitalized - HCCM could not initialize the Node because it failed to resolve the DNS entry for "api.hetzner.cloud".
apricote
added a commit
that referenced
this pull request
Nov 21, 2023
This reverts commit 2c83786 / #560. The commit caused a regression where clusters not using the host network were unable to bootstrap successfully: - CoreDNS did not start because the Node was still tainted as uninitalized - HCCM could not initialize the Node because it failed to resolve the DNS entry for "api.hetzner.cloud".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #559
BEGIN_COMMIT_OVERRIDE
chore(deployment): remove dns-policy (later reverted)
END_COMMIT_OVERRIDE