Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadBalancer does not populate IP field when disable-public-network is set. #553

Open
Tracked by #612
kwohlfahrt opened this issue Nov 4, 2023 · 3 comments
Open
Tracked by #612
Assignees
Labels
bug Something isn't working pinned

Comments

@kwohlfahrt
Copy link

kwohlfahrt commented Nov 4, 2023

I have created a service of type LoadBalancer, with the annotation load-balancer.hetzner.cloud/disable-public-network: "true". The load-balancer has a private IP address assigned on my cluster's network (172.29.0.3), and responds correctly on this address. But, the status does not contain the LB's IP address:

  status:
    loadBalancer: {}

When I create a service without the annotation, the status is correctly updated:

  status:
    loadBalancer:
      ingress:
      - ip: 167.235.<snip>
      - ip: 2a01:4f8:<snip>

I think even if public access is disabled, the external IP should still be populated with the service's private network address, so that servers on my HCloud network (but outside the k8s cluster) can extract the address they can reach the service on. Also, without the load-balancer IP address, external-dns fails to add a record for this load-balancer.

@apricote apricote self-assigned this Nov 30, 2023
@apricote apricote added the bug Something isn't working label Nov 30, 2023
@apricote
Copy link
Member

Yea, this seems to be an oversight. I will cleanup the responsible code and submit a fix to include the private IP if disable-public-network is set. In theory we could always set this if a private network is defined, but that should probably be gated behind a flag, to avoid breaking users with external-dns setups (and similiar).

Copy link
Contributor

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

@github-actions github-actions bot added the stale label Feb 29, 2024
@kwohlfahrt
Copy link
Author

Not stale, this issue persists with 1.19 of the CCM.

@jooola jooola added pinned and removed stale labels Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pinned
Projects
None yet
Development

No branches or pull requests

3 participants