Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation about environment variables #202

Open
process0 opened this issue May 27, 2021 · 5 comments
Open

Better documentation about environment variables #202

process0 opened this issue May 27, 2021 · 5 comments
Assignees
Labels

Comments

@process0
Copy link
Contributor

process0 commented May 27, 2021

Took a minute to figure out i needed to specify HCLOUD_NETWORK in the Deployment environment variables. Are these variables socumented somewhere that I missed? Also would it make more sense to store all of them in a Secret along with the token?

const (
	hcloudTokenENVVar                        = "HCLOUD_TOKEN"
	hcloudEndpointENVVar                     = "HCLOUD_ENDPOINT"
	hcloudNetworkENVVar                      = "HCLOUD_NETWORK"
	hcloudDebugENVVar                        = "HCLOUD_DEBUG"
	hcloudLoadBalancersEnabledENVVar         = "HCLOUD_LOAD_BALANCERS_ENABLED"
	hcloudLoadBalancersLocation              = "HCLOUD_LOAD_BALANCERS_LOCATION"
	hcloudLoadBalancersNetworkZone           = "HCLOUD_LOAD_BALANCERS_NETWORK_ZONE"
	hcloudLoadBalancersDisablePrivateIngress = "HCLOUD_LOAD_BALANCERS_DISABLE_PRIVATE_INGRESS"
	hcloudLoadBalancersUsePrivateIP          = "HCLOUD_LOAD_BALANCERS_USE_PRIVATE_IP"
	nodeNameENVVar                           = "NODE_NAME"
	providerName                             = "hcloud"
	providerVersion                          = "v1.9.1"
)
@LKaemmerling
Copy link
Member

Hey @process0,

when you use our deployment files those ENV variables are already in there.
https://github.com/hetznercloud/hcloud-cloud-controller-manager/blob/master/deploy/ccm-networks.yaml.tmpl#L86
(Used when you follow our docs: https://github.com/hetznercloud/hcloud-cloud-controller-manager/blob/master/docs/deploy_with_networks.md)

But you are right, we will improve the documentation of our Environment variables here.

@LKaemmerling LKaemmerling added the enhancement New feature or request label Jun 4, 2021
@github-actions github-actions bot added the stale label Aug 3, 2021
@hetznercloud hetznercloud deleted a comment from github-actions bot Aug 6, 2021
@LKaemmerling LKaemmerling removed the stale label Aug 6, 2021
@LKaemmerling
Copy link
Member

Removing the staleness,we still want and need to improve this.

@github-actions github-actions bot added the stale label Oct 6, 2021
@hetznercloud hetznercloud deleted a comment from github-actions bot Oct 8, 2021
@LKaemmerling LKaemmerling removed the stale label Oct 8, 2021
@LKaemmerling
Copy link
Member

Removing the staleness,we still want and need to improve this.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

@mrclrchtr
Copy link

It's still not improved right?

@jooola jooola reopened this Sep 25, 2023
@jooola jooola self-assigned this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants