Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): Make default values work with cloud/dedicated hybrid clusters #539

Open
WeaselScience opened this issue Nov 9, 2023 · 2 comments
Labels
enhancement New feature or request pinned

Comments

@WeaselScience
Copy link

WeaselScience commented Nov 9, 2023

The hcloud-csi-controller deployment has no node anti-affinity for nodes labeled with instance.hetzner.cloud/is-root-server=true by default. This means that the pod can get deployed on robot servers, rendering it useless, as it cannot access the API.

The hcloud-csi-node DaemonSet already has anti-affinity for labeled robot nodes, it should probably be added to the deployment aswell.

Copy link

github-actions bot commented Feb 7, 2024

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

@github-actions github-actions bot added the Stale label Feb 7, 2024
@apricote
Copy link
Member

apricote commented Feb 9, 2024

Hey @WeaselScience,

Its not very well documented, but the controller does not need to run on Cloud Nodes if you set the HCLOUD_VOLUME_DEFAULT_LOCATION environment variable to your preferred default location. By default the controller uses the location of the Cloud Server its running on (through the metadata service), but if you configure it you can run it anywhere you like.

This is something that we should make easily configurable through the Helm Chart and change the default to be more user friendly. I will update the issue title as such.

@apricote apricote added enhancement New feature or request pinned and removed Stale labels Feb 9, 2024
@apricote apricote changed the title hcloud-csi-controller can be deployed on robot nodes, breaking it. fix(chart): Make default values work with cloud/dedicated hybrid clusters Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned
Projects
None yet
Development

No branches or pull requests

2 participants