Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.rs: Rename aarch64 compiler_builtins symbols #186

Merged
merged 5 commits into from Dec 5, 2021

Conversation

mkroening
Copy link
Member

@mkroening mkroening commented Dec 5, 2021

The first four commits clean up the code. The last commit is the actual fix for https://github.com/hermitcore/libhermit-rs/runs/4421725682.

The duplicate symbols are from compiler-builtins.

@mkroening mkroening marked this pull request as ready for review December 5, 2021 16:08
@mkroening
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Dec 5, 2021
@bors
Copy link
Contributor

bors bot commented Dec 5, 2021

Copy link
Contributor

@stlankes stlankes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I forgot that we use llvm_objcopy.

@stlankes
Copy link
Contributor

stlankes commented Dec 5, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 5, 2021

@bors bors bot merged commit fc482df into hermit-os:master Dec 5, 2021
@mkroening mkroening deleted the aarch64-symbols branch December 5, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants