Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable mutable-noalias #135

Merged
merged 2 commits into from May 28, 2021
Merged

Conversation

mkroening
Copy link
Member

Fixes #128.

What do you think?

a65d42 mistakenly removed the if not feature clause.
Also we should have similar behaviors regarding outer RUSTFLAGS.
Copy link
Contributor

@stlankes stlankes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. I don't see a better solution.

bors bot added a commit to hermit-os/kernel that referenced this pull request May 28, 2021
198: Disable `mutable-noalias` r=stlankes a=mkroening

See hermit-os/hermit-rs#135.

What do you think?

Co-authored-by: Martin Kröning <mkroening@posteo.net>
@stlankes
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented May 28, 2021

@bors bors bot merged commit 204578e into hermit-os:master May 28, 2021
@mkroening mkroening deleted the disable-mutable-noalias branch December 1, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hermit-sys: Network regression
2 participants