Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade source-map to 0.7.2 to get speed improvements #14

Open
andreicristianpetcu opened this issue Mar 4, 2018 · 3 comments
Open

Comments

@andreicristianpetcu
Copy link

The latest source-map which is v0.7.2 got support for WebAssembly and it is 10 times faster than the old one. More info here:

https://github.com/mozilla/source-map/blob/master/CHANGELOG.md#072
http://fitzgeraldnick.com/2018/02/26/speed-without-wizardry.html
https://hacks.mozilla.org/2018/01/oxidizing-source-maps-with-rust-and-webassembly/
firefox-devtools/debugger#5598

Please update so you would get 10 times speed improvements for your library in Firefox, 9 times in Safari and 5 times in Chrome.

@jonschlinkert
Copy link
Member

it's in the pipeline, thanks

@danez
Copy link
Member

danez commented Apr 10, 2018

Only problem with this is that source-map dropped support for node <8 in this version.

@jonschlinkert
Copy link
Member

I'd like to externalize source maps completely. Perhaps instead of options.sourcemap being a boolean, we can allow the user to pass a function - which could be snapdragon-sourcemaps or a custom function.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants