Remove 'bool' misconception in place of strtobool #71
+34
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luzfcb
suggested changes
Oct 10, 2018
| @@ -3,6 +3,7 @@ | |||
| import pytest | |||
| from mock import patch | |||
| from decouple import AutoConfig, UndefinedValueError, RepositoryEmpty | |||
| from distutils.util strtobool | |||
There was a problem hiding this comment.
a small syntax error. Missing import keyword
from distutils.util import strtobool
| @@ -4,6 +4,7 @@ | |||
| from mock import patch | |||
| import pytest | |||
| from decouple import Config, RepositoryEnv, UndefinedValueError | |||
| from distutils.util strtobool | |||
There was a problem hiding this comment.
same here.
a small syntax error. Missing import keyword
from distutils.util import strtobool
| @@ -4,6 +4,8 @@ | |||
| from mock import patch, mock_open | |||
| import pytest | |||
| from decouple import Config, RepositoryIni, UndefinedValueError | |||
| from distutils.util strtobool | |||
There was a problem hiding this comment.
same here.
a small syntax error. Missing import keyword
from distutils.util import strtobool
| @@ -88,7 +88,7 @@ Then use it on your ``settings.py``. | |||
| .. code-block:: python | |||
|
|
|||
| SECRET_KEY = config('SECRET_KEY') | |||
| DEBUG = config('DEBUG', default=False, cast=bool) | |||
| DEBUG = config('DEBUG', default=False, cast=strtobool) | |||
There was a problem hiding this comment.
"Explicit is better than implicit."
it would be good to add from distutils.util import strtobool to example.
| if value.lower() not in self._BOOLEANS: | ||
| raise ValueError('Not a boolean: %s' % value) | ||
|
|
||
| return self._BOOLEANS[value.lower()] |
There was a problem hiding this comment.
strtobool return 0 and 1. for backward compatibility, should we convert to bool?
There was a problem hiding this comment.
or change the internal api to use strtobool when cast is bool
henriquebastos
force-pushed
the
master
branch
2 times, most recently
from
35931d3 to
774b40f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.