Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No storing of recent patients with no error on Prod/Staging Redis #458

Open
MaxSchaefer opened this issue Oct 5, 2023 · 4 comments
Open

No storing of recent patients with no error on Prod/Staging Redis #458

MaxSchaefer opened this issue Oct 5, 2023 · 4 comments
Assignees
@MaxSchaefer
Labels
bug Something isn't working

Comments

@MaxSchaefer
Copy link
Member

Describe the bug

The decay_lru is not complaining about any problems with redis and is not storing anything in redis. This problem only occurs on Prod/Staging.

Describe how to produce the bug

Using UpdatePatient and GetRecentPatients on Prod/Staging

Additional context

helpwave/web#744
@MaxSchaefer MaxSchaefer added bug Something isn't working priority: high High priority issue labels Oct 5, 2023
@MaxSchaefer MaxSchaefer mentioned this issue Oct 9, 2023
Merged
@FoseFx FoseFx self-assigned this Oct 9, 2023
@DasProffi DasProffi mentioned this issue Oct 10, 2023
Open
@MaxSchaefer MaxSchaefer removed the priority: high High priority issue label Oct 11, 2023
@MaxSchaefer MaxSchaefer added the priority: high High priority issue label Oct 18, 2023
@FoseFx
Copy link
Member

FoseFx commented Oct 19, 2023 •
edited

I replace the upstash instance with a temporary "real" redis instance, and it works fine.

Some Logs 
127.0.0.1:6379> MONITOR
OK
1697716398.310680 [0 [fdaa:2:44d0:a7b:141:4d88:57df:2]:44806] "evalsha" "7a1c3c4f4a4ef54db45c48e5453544d66de490fc" "1" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "ac10b72f-5b55-4a5f-b39e-3bd717166e27" "10" "86400000000000" "20"
1697716398.310746 [0 lua] "TIME"
1697716398.310762 [0 lua] "ZADD" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "1697716398" "ac10b72f-5b55-4a5f-b39e-3bd717166e27"
1697716398.310783 [0 lua] "EXPIRE" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "86400000000000"
1697716398.315802 [0 [fdaa:2:44d0:a7b:141:4d88:57df:2]:35858] "hello" "3" "auth" "(redacted)" "(redacted)"
1697716398.317749 [0 [fdaa:2:44d0:a7b:141:4d88:57df:2]:35858] "evalsha" "7a1c3c4f4a4ef54db45c48e5453544d66de490fc" "1" "recently-viewed-ward-18159713-5d4e-4ad5-94ad-fbb6bb147984" "f7f56ab1-2ec5-4df3-8e55-45a664cd8174" "10" "86400000000000" "20"
1697716398.317794 [0 lua] "TIME"
1697716398.317808 [0 lua] "ZADD" "recently-viewed-ward-18159713-5d4e-4ad5-94ad-fbb6bb147984" "1697716398" "f7f56ab1-2ec5-4df3-8e55-45a664cd8174"
1697716398.317829 [0 lua] "EXPIRE" "recently-viewed-ward-18159713-5d4e-4ad5-94ad-fbb6bb147984" "86400000000000"
1697716403.556287 [0 [fdaa:2:44d0:a7b:141:4d88:57df:2]:35858] "evalsha" "7a1c3c4f4a4ef54db45c48e5453544d66de490fc" "1" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "ac10b72f-5b55-4a5f-b39e-3bd717166e27" "10" "86400000000000" "20"
1697716403.556344 [0 lua] "TIME"
1697716403.556361 [0 lua] "ZADD" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "1697716403" "ac10b72f-5b55-4a5f-b39e-3bd717166e27"
1697716403.556382 [0 lua] "EXPIRE" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "86400000000000"
1697716403.739632 [0 [fdaa:2:44d0:a7b:141:4d88:57df:2]:35858] "evalsha" "7a1c3c4f4a4ef54db45c48e5453544d66de490fc" "1" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "ac10b72f-5b55-4a5f-b39e-3bd717166e27" "10" "86400000000000" "20"
1697716403.739688 [0 lua] "TIME"
1697716403.739702 [0 lua] "ZADD" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "1697716403" "ac10b72f-5b55-4a5f-b39e-3bd717166e27"
1697716403.739726 [0 lua] "EXPIRE" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "86400000000000"
1697716403.786735 [0 [fdaa:2:44d0:a7b:141:4d88:57df:2]:35858] "evalsha" "7a1c3c4f4a4ef54db45c48e5453544d66de490fc" "1" "recently-viewed-ward-18159713-5d4e-4ad5-94ad-fbb6bb147984" "f7f56ab1-2ec5-4df3-8e55-45a664cd8174" "10" "86400000000000" "20"
1697716403.786794 [0 lua] "TIME"
1697716403.786832 [0 lua] "ZADD" "recently-viewed-ward-18159713-5d4e-4ad5-94ad-fbb6bb147984" "1697716403" "f7f56ab1-2ec5-4df3-8e55-45a664cd8174"
1697716403.786853 [0 lua] "EXPIRE" "recently-viewed-ward-18159713-5d4e-4ad5-94ad-fbb6bb147984" "86400000000000"



1697716666.484248 [0 [fdaa:2:44d0:a7b:141:4d88:57df:2]:44806] "evalsha" "7a1c3c4f4a4ef54db45c48e5453544d66de490fc" "1" "recently-viewed-ward-18159713-5d4e-4ad5-94ad-fbb6bb147984" "f7f56ab1-2ec5-4df3-8e55-45a664cd8174" "10" "86400000000000" "20"
1697716666.484307 [0 lua] "TIME"
1697716666.484324 [0 lua] "ZADD" "recently-viewed-ward-18159713-5d4e-4ad5-94ad-fbb6bb147984" "1697716666" "f7f56ab1-2ec5-4df3-8e55-45a664cd8174"
1697716666.484345 [0 lua] "EXPIRE" "recently-viewed-ward-18159713-5d4e-4ad5-94ad-fbb6bb147984" "86400000000000"
1697716666.506327 [0 [fdaa:2:44d0:a7b:141:4d88:57df:2]:44806] "evalsha" "7a1c3c4f4a4ef54db45c48e5453544d66de490fc" "1" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "ac10b72f-5b55-4a5f-b39e-3bd717166e27" "10" "86400000000000" "20"
1697716666.506384 [0 lua] "TIME"
1697716666.506403 [0 lua] "ZADD" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "1697716666" "ac10b72f-5b55-4a5f-b39e-3bd717166e27"
1697716666.506424 [0 lua] "EXPIRE" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "86400000000000"
1697716670.036315 [0 [fdaa:2:44d0:a7b:141:4d88:57df:2]:44806] "zrange" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "0" "9" "rev"
1697716698.554135 [0 [fdaa:2:44d0:a7b:141:4d88:57df:2]:44806] "zrange" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "0" "9" "rev"
1697716703.870644 [0 [fdaa:2:44d0:a7b:141:4d88:57df:2]:44806] "evalsha" "7a1c3c4f4a4ef54db45c48e5453544d66de490fc" "1" "recently-viewed-ward-18159713-5d4e-4ad5-94ad-fbb6bb147984" "f7f56ab1-2ec5-4df3-8e55-45a664cd8174" "10" "86400000000000" "20"
1697716703.870700 [0 lua] "TIME"
1697716703.870717 [0 lua] "ZADD" "recently-viewed-ward-18159713-5d4e-4ad5-94ad-fbb6bb147984" "1697716703" "f7f56ab1-2ec5-4df3-8e55-45a664cd8174"
1697716703.870738 [0 lua] "EXPIRE" "recently-viewed-ward-18159713-5d4e-4ad5-94ad-fbb6bb147984" "86400000000000"
1697716705.210982 [0 [fdaa:2:44d0:a7b:141:4d88:57df:2]:44806] "evalsha" "7a1c3c4f4a4ef54db45c48e5453544d66de490fc" "1" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "ac10b72f-5b55-4a5f-b39e-3bd717166e27" "10" "86400000000000" "20"
1697716705.211040 [0 lua] "TIME"
1697716705.211055 [0 lua] "ZADD" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "1697716705" "ac10b72f-5b55-4a5f-b39e-3bd717166e27"
1697716705.211076 [0 lua] "EXPIRE" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "86400000000000"
1697716707.330110 [0 [fdaa:2:44d0:a7b:141:4d88:57df:2]:44806] "zrange" "recently-viewed-patient-18159713-5d4e-4ad5-94ad-fbb6bb147984" "0" "9" "rev"

The EXPIRE seems a bit high though? I'll take a look at it

@MaxSchaefer
Copy link
Member Author

The EXPIRE seems a bit high though? I'll take a look at it

Okay, thanks for the investigation. Keep us posted. What are the next steps for debugging or alternatives?

MaxSchaefer added a commit that referenced this issue Oct 21, 2023
@MaxSchaefer
fix: workaround for GetRecentPatients
eb6c78c 
Until #458 is fixed
@MaxSchaefer MaxSchaefer mentioned this issue Oct 21, 2023
Merged
MaxSchaefer added a commit that referenced this issue Oct 26, 2023
@MaxSchaefer
fix: workaround for GetRecentPatients (#482)
4520ff1 
Until #458 is fixed
@MaxSchaefer
Copy link
Member Author

@FoseFx I guess deploying Redis on our side, outside Upstash seams like the only option.

@MaxSchaefer MaxSchaefer assigned MaxSchaefer and unassigned FoseFx Dec 12, 2023
@MaxSchaefer MaxSchaefer removed the priority: high High priority issue label Dec 24, 2023
@FoseFx
Copy link
Member

FoseFx commented Apr 2, 2024

Given the license change, valkey.io (Linux Foundation backed fork) might be interesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaxSchaefer MaxSchaefer

Labels
bug Something isn't working
Projects
MVP
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FoseFx @MaxSchaefer